Potential fix for code scanning alert no. 13: Uncontrolled command line#12
Merged
Rootless-Ghost merged 1 commit intomasterfrom Apr 15, 2026
Merged
Potential fix for code scanning alert no. 13: Uncontrolled command line#12Rootless-Ghost merged 1 commit intomasterfrom
Rootless-Ghost merged 1 commit intomasterfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/13
The safest fix without changing intended functionality is to enforce strict command allowlisting before building
ps_scriptinexecute_remote_winrm, using the already-imported_is_allowed_atomic_command. This keeps the endpoint behavior (running allowed atomic commands remotely) while blocking arbitrary user input from reaching the PowerShell interpreter.Make the change in
core/remote_executor.pyinsideexecute_remote_winrm, beforeps_scriptis constructed (before line 161 in the provided snippet). Ifcommandis not allowed, return anExecutionResulterror immediately. This prevents tainted/unapproved input from flowing intosubprocess.run.No new imports or dependencies are required, since
_is_allowed_atomic_commandis already imported in that file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.