Potential fix for code scanning alert no. 2: Uncontrolled command line#17
Merged
Rootless-Ghost merged 1 commit intomasterfrom Apr 25, 2026
Merged
Potential fix for code scanning alert no. 2: Uncontrolled command line#17Rootless-Ghost merged 1 commit intomasterfrom
Rootless-Ghost merged 1 commit intomasterfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/2
General fix: do not accept raw executable command text from the API. Accept a stable identifier (for example
command_id) and resolve it server-side to a hard-coded/embedded allowlisted command literal, then execute only that resolved literal.Best fix here without changing core execution behavior: in
app.py’s execute endpoint, ignorebody["command"]for execution and require acommand_idthat maps to a server-side command dictionary. Keepcommandonly for compatibility in response/logging if needed, but execution must use resolved command text from the allowlist mapping. Incore/executor.py, keep existing_is_allowed_atomic_commandcheck as defense in depth.Concretely:
app.py, in the execute route block (around lines 242–283).command = str(body.get("command", "")).strip()with:command_id,command = COMMANDS.get(command_id),_is_allowed_atomic_command(command, executor_type)validation.core/executor.pyfor sink call once untrusted raw command input is removed at source.Suggested fixes powered by Copilot Autofix. Review carefully before merging.