update build instructions for macos#272
Merged
lyskov merged 1 commit intoRosettaCommons:masterfrom Nov 15, 2023
Merged
Conversation
lyskov
approved these changes
Nov 15, 2023
Member
lyskov
left a comment
lyskov
left a comment
There was a problem hiding this comment.
LGTM, - thank you @nikitalita for adding this!
ldedier-gpfw
pushed a commit
to G-P-S/binder
that referenced
this pull request
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to add arm64 instructions.
Added the least recent version of LLVM for arm64 macos (14.0.6) that I could find because I wasn't sure which LLVM versions that this supported; the binder executable builds fine, at least.