Ensure Binder compatibility with LLVM monorepo structure#313
Merged
lyskov merged 1 commit intoRosettaCommons:masterfrom May 14, 2025
Merged
Conversation
lyskov
approved these changes
May 14, 2025
Member
lyskov
left a comment
lyskov
left a comment
There was a problem hiding this comment.
Looks good to me, - thank you for fixing this @LachlanGreen !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included is a update to the llvm path in the final build command. This is necessary because while LLVM 6.0.1 originally used a multi-repo structure, the llvmorg-6.0.1 tag has since been retroactively added to the monorepo. As a result, the build must now target the llvm/ subdirectory inside llvm-project.