Skip to content

Conversation

@adrianxlopez
Copy link

Before submitting this pull request, please go through the checklist below.
If you're doing something in the checklist, put an x inside [ ] so that - [ ] becomes - [x]

  • I have added a screenshot from browser with my changes
  • There are no errors in the console
  • I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
  • There are some things I'd like to improve in this tutorial. I have written them below.
Notes:

When pushing your changes to github, you mention

git push -u origin add-<your-github-id>

I would suggest:

git push -u origin <your-github-id>

to avoid confusion, as I was using the add- portion as part of the code. Also, I would provide a code block to specifically change to contributors/ and then make your .html file as I was having issues with committing because my .html file was not in the contributors/ folder.

cd contributors

Other than that, great walkthrough, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants