The plugin TidyAll::Plugin::OTOBO::Common::Origin has the purpose to check for correct origin line if customization markers are found in a file. The customization marker style in OTOBO has changed, and therefor the plugin does not find customization markers anymore.
Also, the threshold of 5 lines is too restrictive, as usually the origin line is found on line 7 or even below in OTOBO package custom files:
|
last ORIGINLINE if $LineCounter > 5; |
|
last LINE if $Counter > 5; |
From a code quality point of view, I'd even go as far as suggesting to replace the hardcoded value of 5 with a constant, to at least have only one place in the file to control it.
The plugin
TidyAll::Plugin::OTOBO::Common::Originhas the purpose to check for correct origin line if customization markers are found in a file. The customization marker style in OTOBO has changed, and therefor the plugin does not find customization markers anymore.Also, the threshold of 5 lines is too restrictive, as usually the origin line is found on line 7 or even below in OTOBO package custom files:
codepolicy/Kernel/TidyAll/Plugin/OTOBO/Common/Origin.pm
Line 129 in ae69ee2
codepolicy/Kernel/TidyAll/Plugin/OTOBO/Common/Origin.pm
Line 188 in ae69ee2
From a code quality point of view, I'd even go as far as suggesting to replace the hardcoded value of 5 with a constant, to at least have only one place in the file to control it.