Actually update service load balancers #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowhand
approved these changes
Dec 23, 2020
dhrrgn
approved these changes
Dec 24, 2020
dhrrgn
left a comment
dhrrgn
left a comment
There was a problem hiding this comment.
Looks good. If we were to do a proper OSS release, we should add some error handling to ensure the shape of the loadBalancers config value. Not necessary right now though (if we did fully OSS this, we should define the validation schema)
Collaborator
Author
|
💯. There's so much of this that needs validation. I've had similar thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After troubleshooting further, I realized that the load balancer implementation was actually missing a few things.