Skip to content

Conversation

@BenCoffeed
Copy link
Collaborator

Adds ability to specify a Resource Logical name for implementations that create load balancers and target groups within the resource sections of the serverless.yml file. This is important because the CloudFormation update task will fail if the referenced target group is not already associated with an existing ELB. Ultimately, we should probably weigh whether we want to

  1. continue support in this manner.
  2. configure the plugin such that a target group + elb are created VIA the plugin and disable support for pre-existing target groups
    or
  3. Find a way to both support existing target groups OR have the plugin create a new target group/elb pair and set dependencies accordingly.

@BenCoffeed BenCoffeed force-pushed the feature/addElbResourceSuppport branch from 775342f to 045be7c Compare January 13, 2021 16:14
@BenCoffeed BenCoffeed merged commit 9add107 into develop Jan 13, 2021
@BenCoffeed BenCoffeed deleted the feature/addElbResourceSuppport branch January 13, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants