feat: add missing finding status helper#48
Merged
Conversation
change typing from list to Sequence, keep filtering and add the missing find status function
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the backend repository layer to support more flexible retrieval of findings for a scan and adds a helper to update a finding’s status (aligned with issue #5’s persistence layer work).
Changes:
- Renamed
list_findingstoget_findings_by_scanand added optionalfiltersto build dynamic query predicates. - Added
update_finding_statusto persist a status change on an existingFindingORMand refresh it.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Ensure update_finding_status accepts FindingStatus and stores its canonical value.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Rowuni
reviewed
May 16, 2026
Rowuni
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue liée
F4
link : #5
Description
This pull request refactors and extends the findings repository functions to make them more flexible and to support updating finding statuses. The most significant changes include renaming and enhancing the findings query function to support filtering, and adding a new function to update the status of a finding.
Changements
Backend
list_findingstoget_findings_by_scanand added support for dynamic filtering via afiltersdictionary parameter, allowing queries for findings with additional criteria.update_finding_status, a new function that updates the status of a givenFindingORMobject, commits the change, and refreshes the object from the database.change typing from list to Sequence, keep filtering and add the missing find status functionFrontend
Checklist
tsc --noEmitpasse sans erreuruvicorn main:app)