feat(S1): Windows Certificate Store scanning#55
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the S1 scanner for the Windows Certificate Store and adds a generated Markdown report (agent/scan_results.md) to present scan findings grouped by severity, alongside categorized logging output.
Changes:
- Add a Windows Certificate Store scanner (
wincertstore+cryptography) that parses certs, computes severity, and emits actionable recommendations. - Generate a Markdown report (
scan_results.md) after each run summarizing findings by scanner and severity. - Update logging to include level categories (e.g.,
[INFO],[WARNING]), and ignore the generated report via.gitignore.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
agent/scanners/cert_store.py |
Implements Windows cert store enumeration/parsing with severity, details, and recommendations. |
agent/scanners/__init__.py |
Documents a cross-scanner convention for algorithm label formatting. |
agent/scan.py |
Adds Markdown report generation and logging formatting; aggregates scanner results. |
.gitignore |
Ignores the generated scan_results.md report file. |
Comments suppressed due to low confidence (1)
agent/scan.py:83
- The sorting key treats
severity=Noneas unknown (falls back to 99), so findings that explicitly haveseverity: nullwill be pushed to the end instead of being treated as "info". Consider normalizing withx.get('severity') or 'info'before looking up_SEV_ORDER.
for f in sorted(findings, key=lambda x: _SEV_ORDER.get(x.get("severity", "info"), 99)):
sev = f.get("severity", "info")
algo = f.get("algorithm") or "—"
store = f.get("store_or_path") or f.get("key_path") or f.get("path") or "—"
name = str(f.get("name") or "—")[:50]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue liée
close: #7
Description
Scanning du Windows Certificate Store et affichage de tout ce qui a été trouvé, classé suivant la sévérité. Le résultat de chaque scan se trouvera dans le fichier agent/scan_results.md, qui sera créé ou écrasé à chaque scan (fichier ajouté au gitignore)
Aussi, j'ai ajouté des catégories aux logs, comme [ERROR] ou [WARNING].
Pour tester :
Puis regarder le fichier scan_results.md
Changements
Backend
Frontend
Checklist
tsc --noEmitpasse sans erreuruvicorn main:app)