feat: added crypto libraries analysis and updated setup.md accordingly#72
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the agent’s S5 “crypto libraries” scanner by adding a small command-execution helper and initial Windows-focused detection for OpenSSL and SChannel, and documents the helper in SETUP.md.
Changes:
- Implemented
run_command()plus OpenSSL executable discovery/version parsing and SChannel weak-protocol registry checks inagent/scanners/crypto_libs.py. - Updated
CryptoLibFindingto include PQ readiness and adetailsfield. - Added a short note in
SETUP.mdabout reusing the new helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
agent/scanners/crypto_libs.py |
Adds command runner + OpenSSL/SChannel detection logic and expands the crypto libs finding model. |
SETUP.md |
Documents the new reusable run_command() helper. |
Rowuni
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue liée
close: #11
Description
New function within crypto_libs.py to let devs use shell commands and get the output.
Tests
Example code to use the functions is at the bottom of the crypto_libs file.
Changements
Added details in setup.md to explain how and from where to use the shell commands function.
Checklist
tsc --noEmitpasse sans erreuruvicorn main:app)