chore: post-SC code review — remove emojis, fix French strings, refactor enrichment, add docstrings#77
Merged
Merged
Conversation
Closed
…t _enrich_recommendations
Copilot
AI
changed the title
[WIP] Review repository post SC for POC demonstration
chore: post-SC code review — remove emojis, fix French strings, refactor enrichment, add docstrings
May 25, 2026
Rowuni
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-scoring-completion code review pass across the agent codebase. Addresses encoding risks from emoji in source, non-English output strings, a function violating SRP, and missing public API documentation.
agent/scan.py_SEV_ICON(🔴🟠🟡🟢⚪) replaced with ASCII_SEV_LABEL([CRIT]/[HIGH]/[MED]/[LOW]/[INFO]) in both the Markdown table header and per-finding rows"rapport JSON"/"rapport Markdown"→"JSON report"/"Markdown report"_enrich_risk_scores()had two distinct loops (risk scoring + recommendation enrichment); the second extracted into_enrich_recommendations(), both called fromrun_scan()agent/scoring/criticality_factor.pycategory_from_source()andcriticality_factor()agent/scanners/crypto_libs.pydetect_openssl()andscan_crypto_libs()