Adds support for url embeds for message and tab tags#146
Merged
Conversation
MShultz
force-pushed
the
fix/check-for-parent-tags
branch
from
996d319 to
1fc3180
Compare
MShultz
changed the title
Alteras1
approved these changes
Jun 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
text message,message,tabs, andtabtags to correctly render url embeds of the same keyword.There are some special cases where rendering fails, such as attempting to use a child keyword as the text for an url embedd in an otherwise valid parent/child relationship. Such a case is not supported with the BBCode engine at this time. Examples:
[textmessage][message=me]This message won't render the bbcode [message](https://google.com)[/message][/textmessage][tabs][tab]This tab also won't render the bbcode [tab](https://google.com)[/tab][/tabs]Also adds optional chaining to all the tags to avoid undefined errors.