chore(native): bump vendored Zireael to v1.3.11#219
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR introduces v2 drawlist support by adding a new BLIT_RECT command opcode and dedicated command structure, updating version macros and vendor commit references, relaxing drawlist version validation to accept both v1 and v2 while enforcing v1 for event batches, and implementing complete BLIT_RECT handling including bounds validation and execution logic with framebuffer synchronization improvements. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/native/vendor/zireael/include/zr/zr_drawlist.h`:
- Around line 66-67: Add the missing ZR_DL_OP_BLIT_RECT opcode to the TypeScript
drawlist spec and docs: update scripts/drawlist-spec.ts to include an entry for
ZR_DL_OP_BLIT_RECT = 14 (matching the native symbol ZR_DL_OP_BLIT_RECT), then
run npm run codegen and npm run codegen:check to regenerate and validate the
generated protocol bindings, update docs/protocol/zrdl.md to document the
BLIT_RECT command and docs/protocol/versioning.md to record the protocol change,
and add/adjust tests to cover the new BLIT_RECT opcode handling in the drawlist
serialization/deserialization logic.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
packages/native/vendor/VENDOR_COMMIT.txtpackages/native/vendor/zireael/include/zr/zr_drawlist.hpackages/native/vendor/zireael/include/zr/zr_version.hpackages/native/vendor/zireael/src/core/zr_config.cpackages/native/vendor/zireael/src/core/zr_drawlist.cpackages/native/vendor/zireael/src/core/zr_engine_present.incpackages/native/vendor/zireael/src/core/zr_framebuffer.c
💤 Files with no reviewable changes (1)
- packages/native/vendor/zireael/src/core/zr_framebuffer.c
Summary
packages/native/vendor/zireael/{include,src}to upstream tagv1.3.11packages/native/vendor/VENDOR_COMMIT.txtto9e9ea6f54e3b83b60d6457b06646d5c488b94156Validation
cargo testinpackages/nativecompiles the wrapper and vendor successfullymainand this branch:npm -w @rezi-ui/native run build:nativefails withENOVERSIONSfornapimainand this branch:cargo test tests::diff_emits_dim_and_normal_intensity_sequences -- --exactsegfaultsUpstream
v1.3.11Summary by CodeRabbit
New Features
Improvements