🔀🚑️ GitHub device flow login #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror handling This commit refactors the GitHub OAuth process to enhance reliability and user experience. It introduces: - App lifecycle integration: The login process now resumes correctly when the app returns to the foreground, ensuring users aren't interrupted. - Improved error handling: Robust error logging and handling are implemented throughout the OAuth flow for better debugging and resilience. - State management: The `GitHubAuth` class now tracks the login process state, preventing issues with concurrent login attempts. - Token polling: The token retrieval process is refined with a limited number of attempts and clearer success/failure indicators. - Dialog display: The user code dialog is now shown before launching the browser for a more consistent flow.
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (4)
- lib/utility/github_oauth_handler.dart: Language not supported
- lib/views/home_view.dart: Language not supported
- lib/widgets/login.dart: Language not supported
- test/widget_test.dart: Language not supported
Merged
Friedinger
approved these changes
Apr 1, 2025
Member
|
Info: #16 was also included in this pull request |
IamPekka058
pushed a commit
that referenced
this pull request
Aug 8, 2025
🔀🚑️ GitHub device flow login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the GitHub OAuth login process and enhance error logging. The most important changes include the introduction of new methods to handle the login process, better error handling, and improvements to the lifecycle management of the login button widget.
Enhancements to GitHub OAuth login process:
lib/utility/github_oauth_handler.dart: IntroducedstartLoginProcess,pollForToken,resetHandler, and_retrieveDataFromResponsemethods to handle the login process more effectively and added detailed logging for errors. [1] [2] [3]Lifecycle management improvements:
lib/widgets/login.dart: AddedWidgetsBindingObservertoLoginButtonto manage the app lifecycle state changes and ensure the login process continues when the app is resumed. [1] [2]Error logging enhancements:
lib/utility/github_oauth_handler.dart: Addeddart:developerfor logging errors and important events during the OAuth process. [1] [2]lib/widgets/login.dart: Addeddart:developerfor logging app lifecycle state changes.Minor improvements:
lib/views/home_view.dart: Added a check formountedbefore navigating to ensure the widget is still in the widget tree.test/widget_test.dart: Removed unused imports to clean up the test file.