🔀♻️ Improve GitHub OAuth handling #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Improves GitHub OAuth handling by limiting login attempts, enhancing logging and error messaging, and adding unit tests for the TokenHandler.
- Added a new testing dependency (mocktail) for unit tests.
- Updated OAuth handling and logging improvements.
- Enhanced error handling in the GitHub login button.
Files not reviewed (4)
- lib/utility/github_oauth_handler.dart: Language not supported
- lib/utility/token_handler.dart: Language not supported
- lib/widgets/github_login_button.dart: Language not supported
- test/utiltiy/token_handler_test.dart: Language not supported
Friedinger
requested changes
Apr 2, 2025
…nd improve login attempt logic
Ruby11235
requested changes
Apr 2, 2025
Member
Ruby11235
left a comment
Ruby11235
left a comment
There was a problem hiding this comment.
- When choosing to login with GitHub, you should not be sent to Browser when not clicking on 'copy code'
- Change language of said button to english
- Add max login attempts to login with token
… max login attempts
There was a problem hiding this comment.
Copilot reviewed 3 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (17)
- lib/app.dart: Language not supported
- lib/scheme/app_color.dart: Language not supported
- lib/utility/github_oauth_handler.dart: Language not supported
- lib/utility/token_handler.dart: Language not supported
- lib/views/home_view.dart: Language not supported
- lib/views/login_github_view.dart: Language not supported
- lib/views/login_token_view.dart: Language not supported
- lib/views/login_view.dart: Language not supported
- lib/views/welcome_view.dart: Language not supported
- lib/widgets/app_bar.dart: Language not supported
- lib/widgets/app_title.dart: Language not supported
- lib/widgets/github_code_dialog.dart: Language not supported
- lib/widgets/github_login_button.dart: Language not supported
- lib/widgets/login_toke_input.dart: Language not supported
- lib/widgets/page_title.dart: Language not supported
- lib/widgets/text_link.dart: Language not supported
- test/utility/token_handler_test.dart: Language not supported
Ruby11235
approved these changes
Apr 5, 2025
Friedinger
approved these changes
Apr 5, 2025
IamPekka058
pushed a commit
that referenced
this pull request
Aug 8, 2025
🔀♻️ Improve GitHub OAuth handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the GitHub OAuth handling, enhance error messaging, and add unit tests for the
TokenHandlerclass. The most important changes include adding a maximum login attempt limit, improving logging, and adding mock tests for theTokenHandler.Enhancements to GitHub OAuth handling:
lib/utility/github_oauth_handler.dart: Added amaxLoginAttemptsvariable to limit the number of login attempts and updated the logging levels to be more consistent. [1] [2] [3] [4]Error messaging improvements:
lib/widgets/github_login_button.dart: Updated the login button text to "Login with GitHub" and added error handling to show a snackbar message when login fails. [1] [2]Unit tests:
test/utiltiy/token_handler_test.dart: Added unit tests for theTokenHandlerclass usingmocktailto mockFlutterSecureStorage.Dependency updates:
pubspec.yaml: Addedmocktailas a dependency for unit testing.Minor changes:
lib/utility/token_handler.dart: Removed thefinalkeyword from thestoragevariable to allow it to be mocked in tests.