Skip to content

Conversation

@Friedinger
Copy link
Member

This pull request includes updates to the GitHubAuth class in lib/core/models/github_oauth_model.dart. The changes include updating the clientId constant and adding a new getter for authentication status.

Updates to GitHubAuth class:

  • Updated the clientId constant value to a new string, likely for security or configuration purposes. ([lib/core/models/github_oauth_model.dartL8-R8](https://github.com/RubberDuckCrew/gitdone/pull/44/files#diff-5e86a8c72c287d7342199ca70a78a320f2591b7e3a300fd600d09bb13fce4610L8-R8))
  • Added a new isAuthenticated getter to expose the _authenticated field, providing a way to check the authentication status externally. ([lib/core/models/github_oauth_model.dartR100](https://github.com/RubberDuckCrew/gitdone/pull/44/files#diff-5e86a8c72c287d7342199ca70a78a320f2591b7e3a300fd600d09bb13fce4610R100))

@Friedinger Friedinger added the ♻️ Refactor Code improvements without changing function label Apr 17, 2025
@Friedinger Friedinger requested a review from IamPekka058 April 17, 2025 13:25
@Friedinger Friedinger linked an issue Apr 17, 2025 that may be closed by this pull request
2 tasks
@Friedinger Friedinger merged commit c45e67b into chore/change-Structure Apr 17, 2025
2 checks passed
@Friedinger Friedinger deleted the refactor/switch-to-githubapp branch April 17, 2025 13:46
IamPekka058 pushed a commit that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ Refactor Code improvements without changing function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️ Replace OAuth Client ID with GitHub App credentials

3 participants