🔀 Merge flutterSetup in main #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created `App.dart` to manage the app's navigation. - Created `TokenHandler` to handle token management. - Created `HomeView` and `LoginView` to display the main and login screens. - Moved the old demo `main.dart` code to a separate location. - Added `flutter_secure_storage` as dependency. - Added `flutter_web_auth_2`, `http` and `android_intent_plus` as dependencies.
Due to https://dart.dev/tools/linter-rules/file_names - Renamed `App.dart` to `app.dart`. - Renamed `loginView.dart` to `login_view.dart`. - Renamed `Appbar.dart` to `app_bar.dart`. - Renamed `HomeView.dart` to `home_view.dart`. - Renamed `AppColors.dart` to `app_color.dart`. - Renamed `TokenHandler.dart` to `token_handler.dart`. - Renamed `GithubApiHandler.dart` to `github_api_handler.dart`. - Updated all imports to reflect these changes.
Refresh button is just a fun feature. Needs to be deleted
- Uses a provider to provide the octocat to the OctoCat widget. - Add refresh logic to the OctoCatProvider. - Remove fetch logic from the widget to provider. - Allow fetching a new octocat via the provider. - Provide `futureResponse` as the data source.
- Update dependencies in `pubspec.yaml` and `pubspec.lock` to their latest compatible versions. - Removed unused dependencies: `flutter_web_auth_2`, `desktop_webview_window`, `flutter_web_auth_2_platform_interface`, and `window_to_front`.
This commit introduces the implementation of GitHub's device flow authentication. It includes: - A new `GitHubAuth` class to handle the authentication process. - A `GithubCodeDialog` widget to display the user code. - The ability to poll for an access token after the user authorizes the app.
…ve token polling logic
…button to show loading indicator
There was a problem hiding this comment.
Pull Request Overview
This PR sets up the initial Flutter project configuration by adding key files and settings needed for project metadata, linting, and Android build configuration.
- Added analysis_options.yaml to configure Flutter lints.
- Created a new README.md providing basic project information.
Reviewed Changes
Copilot reviewed 20 out of 38 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| analysis_options.yaml | Added Flutter lint configuration |
| README.md | Added project documentation with initial Getting Started info |
Files not reviewed (18)
- .metadata: Language not supported
- android/.gitignore: Language not supported
- android/app/build.gradle: Language not supported
- android/app/src/debug/AndroidManifest.xml: Language not supported
- android/app/src/main/AndroidManifest.xml: Language not supported
- android/app/src/main/kotlin/com/GitDone/gitdone/MainActivity.kt: Language not supported
- android/app/src/main/res/drawable-v21/launch_background.xml: Language not supported
- android/app/src/main/res/drawable/launch_background.xml: Language not supported
- android/app/src/main/res/values-night/styles.xml: Language not supported
- android/app/src/main/res/values/styles.xml: Language not supported
- android/app/src/profile/AndroidManifest.xml: Language not supported
- android/build.gradle: Language not supported
- android/gradle.properties: Language not supported
- android/gradle/wrapper/gradle-wrapper.properties: Language not supported
- android/settings.gradle: Language not supported
- lib/app.dart: Language not supported
- lib/main.dart: Language not supported
- lib/scheme/app_color.dart: Language not supported
Comments suppressed due to low confidence (1)
README.md:1
- The project title 'gitdone' in the README.md header does not seem to align with the Flutter project setup described in the PR metadata. Consider updating it to a title that better reflects the project's purpose.
# gitdone
There was a problem hiding this comment.
Pull Request Overview
This PR sets up a new Flutter project by introducing essential configuration and documentation files.
- Added analysis options for Dart linting
- Created a README with getting started instructions
Reviewed Changes
Copilot reviewed 21 out of 39 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| analysis_options.yaml | Adds Dart analyzer configurations and lint rules |
| README.md | Provides initial project documentation |
Files not reviewed (18)
- .metadata: Language not supported
- android/.gitignore: Language not supported
- android/app/build.gradle: Language not supported
- android/app/src/debug/AndroidManifest.xml: Language not supported
- android/app/src/main/AndroidManifest.xml: Language not supported
- android/app/src/main/kotlin/com/GitDone/gitdone/MainActivity.kt: Language not supported
- android/app/src/main/res/drawable-v21/launch_background.xml: Language not supported
- android/app/src/main/res/drawable/launch_background.xml: Language not supported
- android/app/src/main/res/values-night/styles.xml: Language not supported
- android/app/src/main/res/values/styles.xml: Language not supported
- android/app/src/profile/AndroidManifest.xml: Language not supported
- android/build.gradle: Language not supported
- android/gradle.properties: Language not supported
- android/gradle/wrapper/gradle-wrapper.properties: Language not supported
- android/settings.gradle: Language not supported
- lib/app.dart: Language not supported
- lib/main.dart: Language not supported
- lib/scheme/app_color.dart: Language not supported
Comments suppressed due to low confidence (1)
README.md:1
- [nitpick] The project title 'gitdone' may not clearly reflect the Flutter project setup; consider updating it to a name that aligns with the project's purpose, such as 'flutterSetup' or a more descriptive title.
# gitdone
Friedinger
previously approved these changes
Mar 27, 2025
Friedinger
approved these changes
Mar 27, 2025
IamPekka058
added a commit
that referenced
this pull request
Aug 8, 2025
🔀 Merge flutterSetup in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new files and configurations to set up a Flutter project, including metadata tracking, project structure, and initial configurations for Android. Below are the most important changes grouped by theme:
Project Metadata and Configuration:
.metadatafile to track properties of the Flutter project, including version, channel, project type, and migration details (.metadata).Documentation:
README.mdwith basic information about the Flutter project and resources for getting started (README.md).Linting and Analysis:
analysis_options.yamlto configure the Dart analyzer with recommended lints for Flutter apps, packages, and plugins (analysis_options.yaml).Android Configuration:
android/app/build.gradle, including plugin management, compile options, and build types (android/app/build.gradle).android/app/src/debug/AndroidManifest.xml,android/app/src/main/AndroidManifest.xml,android/app/src/profile/AndroidManifest.xml). [1] [2] [3]android/gradle/wrapper/gradle-wrapper.properties,android/settings.gradle). [1] [2]Flutter App Initialization:
lib/main.dartandlib/app.dart, including theme setup and authentication check (lib/main.dart,lib/app.dart). [1] [2]lib/scheme/app_color.dart(lib/scheme/app_color.dart).