Skip to content

Handle JSON event query responses that contain a nil result field #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frozenbubbleboy wants to merge 2 commits into from
Closed

Handle JSON event query responses that contain a nil result field #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80de4c4
Handle JSON event query responses that contain a nil result field
frozenbubbleboy May 10, 2016
552c113
Update jsonapi.rb
frozenbubbleboy May 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/zenoss/jsonapi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ def parse_json(resp)
end

json = JSON.load(resp.http_body.content)
# Handle the situation where the 'result' key in the JSON response does not
# point to a hash, but instead is nil.
# This has been seen in the wild on an installation of Zenoss 4.2.5
if json['result'].nil?
raise ZenossError, "JSON request '#{json['method']}' on '#{json['action']}' returned malformed data"
end

# Check for JSON success. There are some exceptions where this doesn't make sense:
# 1. Sometimes the 'success' key does not exist like in EventsRouter#query
# 2. When json['result'] is not a Hash like a return from ReportRouter#get_tree
Expand Down