Merged
Conversation
pedramamini
approved these changes
Nov 27, 2025
This was referenced Nov 28, 2025
Merged
Merged
Merged
This was referenced Dec 14, 2025
Merged
Merged
This was referenced Dec 28, 2025
6 tasks
5 tasks
reachraza
added a commit
that referenced
this pull request
Feb 6, 2026
Address PR review feedback: - Issue #1: Add early returns in openModal, closeModal, and closeAll to skip Map recreation when state hasn't changed. Prevents unnecessary selector re-evaluations across all subscribers. - Issue #2: Add JSDoc to useModalActions() explaining that the ~40 selector subscriptions are intentionally transitional — identical to old Context behavior. Components should migrate to direct useModalStore(selectModalOpen(...)) calls for granular subscriptions. - Issue #5: Add 14 new tests covering no-op guard behavior (7 tests including render count verification), getModalActions() API surface and cross-call store sharing (3 tests), and useModalActions() reactive state and compatibility (4 tests). Issues #3 (memory leak) and #4 (type overloads) are not actionable: 47 fixed modal IDs is bounded, and ModalDataFor<T> already resolves to undefined for unmapped modals.
Merged
claudepalmeragent
pushed a commit
to claudepalmeragent/Maestro
that referenced
this pull request
Feb 9, 2026
Adds investigation and planning documents for: 1. PRICING-BUGFIXES-PHASE2.md - Summary of 5 issues found during testing: - Issue RunMaestro#1: Agent Settings Detection - WORKING CORRECTLY - Issue RunMaestro#2: Folder Toggle Shows Blank - Minor bug, fix ready - Issue RunMaestro#3: Folder Detection Shows API - Critical bug, fix ready - Issue RunMaestro#4: Analysis of RunMaestro#1 vs RunMaestro#3 - Issue RunMaestro#5: Dashboard costs - Requires separate plan 2. PRICING-DASHBOARD-COST-FIX.md - Comprehensive plan for Issue RunMaestro#5: - Root cause: Costs stored at API rates, billing mode never applied - Solution: Recalculate at storage time with proper billing mode - 6-phase implementation plan with database schema changes - Risk assessment and mitigation strategies - Timeline estimate: 12-18 hours Auto Run fix documents created in /app/__AUTORUN/: - PRICING-FIX-02-FOLDER-TOGGLE.md - PRICING-FIX-03-FOLDER-DETECTION.md Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
claudepalmeragent
pushed a commit
to claudepalmeragent/Maestro
that referenced
this pull request
Feb 9, 2026
…unMaestro#3) Issue RunMaestro#2 - Folder toggle shows blank: - Updated calculateProjectBillingState() to check detected modes when all agents are 'auto' - If all detected modes match, shows that mode instead of 'mixed' Issue RunMaestro#3 - Folder shows "API Key" instead of "Max": - Extract SSH remote ID from session.sessionSshRemoteConfig when enabled - Pass sshRemoteId to detectAuth() call for proper detection - Added debug logging for verification Also: - Archived original pricing enhancement plan - Updated PRICING-BUGFIXES-PHASE2.md to reflect completed status - Added 6 new unit tests for SSH remote detection Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says. Maestro came up without having found 'claude`. Turns out: