Fix SSH remote git diff viewer and log operations#380
Merged
pedramamini merged 6 commits intoRunMaestro:mainfrom Feb 16, 2026
Merged
Fix SSH remote git diff viewer and log operations#380pedramamini merged 6 commits intoRunMaestro:mainfrom
pedramamini merged 6 commits intoRunMaestro:mainfrom
Conversation
…optional sshRemoteId
…pport SSH remote execution
- Add optional sshRemoteId prop to GitLogViewer component - Pass sshRemoteId to git.log, git.commitCount, and git.show API calls - Update AppModals to pass active session SSH remote ID to GitLogViewer - Fix tests to expect the new sshRemoteId parameter in API calls
… SSH-aware git IPC Check sessionSshRemoteConfig.enabled before using remoteId to prevent local sessions from incorrectly resolving to SSH remote paths. Update global.d.ts type definitions to reflect SSH-aware IPC API signatures (log, commitCount, show, branches, tags). Update test mocks to use execGitRemote/execGit and fix settingsStore mock setup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add missing import for clearCapabilitiesCache/setCapabilitiesCache in MainPanel test - Make beforeEach async in git test to support dynamic import of remote-git module - Add id and enabled fields to SSH remote assertion objects to match actual config shape passed through - Add execFileNoThrow mock for merge commit test (local, non-SSH path) - Fix JSDOM text assertion: CSS uppercase class doesn't transform text in test environment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pedramamini
added a commit
that referenced
this pull request
Feb 16, 2026
…/deleted tests - Add sessionSshRemoteConfig.enabled guard to handleViewGitDiff in App.tsx (was the only site missing it after PR #380) - Remove duplicate git:log SSH remote test - Restore deleted "large commit counts" test for git:commitCount - Restore deleted "merge commits with multiple parents" test for git:show
Collaborator
|
Merged — nice work on the SSH git plumbing. Pushed a follow-up fix in Bug fix:
Test cleanup:
|
pedramamini
added a commit
that referenced
this pull request
Feb 16, 2026
…ions - SymphonyModal RepositoryTile: use justify-between for header alignment - SymphonyModal Enter key handler: add block scoping to fix lint warning - Fix git preload test to account for sshRemoteId parameter from PR #380 - Fix useSymphony test indentation that broke describe block nesting Claude ID: 471ba427-2670-45b3-96aa-a1d628c6e7f4 Maestro ID: b9bc0d08-5be2-4fdf-93cd-5618a8d53b35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.tsx,MainPanel.tsx, andAppModals.tsxto checksessionSshRemoteConfig.enabledbefore usingremoteId, preventing local sessions from incorrectly resolving to SSH remote pathsgit:log,git:commitCount,git:show) and preload API, enabling git log viewer and diff operations to work over SSH connectionsGitLogViewercomponent, passingsshRemoteIdthrough to all git operations (log, show, commit count)global.d.tstype definitions to reflect SSH-aware IPC API signatures with optionalsshRemoteIdparametersexecGitRemote/execGit, andMainPanel/QuickActionsModalSSH scenariosTest plan
npm run testpasses for affected test filesnpm run lintpasses🤖 Generated with Claude Code