fix: prevent duplicate CLI flags in buildAgentArgs#399
Merged
pedramamini merged 2 commits intoRunMaestro:mainfrom Feb 17, 2026
Merged
fix: prevent duplicate CLI flags in buildAgentArgs#399pedramamini merged 2 commits intoRunMaestro:mainfrom
pedramamini merged 2 commits intoRunMaestro:mainfrom
Conversation
Contributor
Author
|
@pedramamini switch to CodeRabbit? https://www.coderabbit.ai/pricing OIDC error on claude review. Config error? |
Contributor
Author
|
Added follow-up commit for Wizard/Codex behavior:
Commit: 2fa8dd2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildAgentArgs()while preserving order-/--), leaving positional args unchangedWhy
When both batch mode and YOLO mode contribute the same flag (for example Codex
--dangerously-bypass-approvals-and-sandbox), the final argv can contain duplicates and Codex exits with code 2.Fixes #398
Follow-up Fix (Wizard/Codex)
agent_messageevents occur in one turnStdoutHandler.test.tsto ensure only the final Codex message is emittedThis addresses cases where Wizard got stuck showing interim text like "I’m checking the directory..." instead of the actual final answer.