This repository was archived by the owner on Jun 7, 2023. It is now read-only.
Fix: Correct sending an undefined answer. #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a students clicks "check me" on an mchoice without selecting an answer, the code returns "undefined" instead of an empty string.
bnmnetp
approved these changes
Dec 10, 2021
| }</li>`; | ||
| this.feedbackString += `<li value="${i + 1}">${ | ||
| this.feedbackList[i] | ||
| }</li>`; |
Member
There was a problem hiding this comment.
This block looks like it should be hand formatted. Not sure what formatter thinks it is a good idea to do ${ on one line and } after it makes it really hard to see that it is jQuery.
Contributor
Author
There was a problem hiding this comment.
I'll revert this. I use Prettier to format JS.
Contributor
Author
There was a problem hiding this comment.
But also, this isn't JQuery, it's a template literal.
Contributor
Author
There was a problem hiding this comment.
Here's the code before Prettier:
this.feedbackString += `<li value="${i + 1}">${this.feedbackList[i]
}</li>`;This seems worse than what Prettier did to it!
Contributor
Author
There was a problem hiding this comment.
So on second thought, let's leave this change in.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a students clicks "check me" on an mchoice without selecting an answer, the code returns "undefined" instead of an empty string.