Matching: use queuMathJax instead of typesetPromise#1172
Merged
bnmnetp merged 1 commit intoRunestoneInteractive:mainfrom Mar 8, 2026
Merged
Matching: use queuMathJax instead of typesetPromise#1172bnmnetp merged 1 commit intoRunestoneInteractive:mainfrom
bnmnetp merged 1 commit intoRunestoneInteractive:mainfrom
Conversation
bnmnetp
approved these changes
Mar 8, 2026
Member
|
Thanks, the components should always use queueMathJax to ensure we are not trying to typeset multiple things at the same time. This one just didn't get updated from the initial prototype. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should fix:
https://groups.google.com/g/pretext-dev/c/iIy3kSG-WqY/m/9IsTgEPjAgAJ?utm_medium=email&utm_source=footer
And possibly:
#762
I don't believe matching should be triggering a full
typesetPromiseon init. Depending on the timing, this can cause the typeset that is supposed to process the rest of the page to try to convert elements that have already been converted.Definitely should only target its own content. Not sure about using queueMathJax, but that seems wise too.