LTI1p3: update timezone handling to accomodate Canvas change#1189
Merged
bnmnetp merged 1 commit intoRunestoneInteractive:mainfrom Mar 26, 2026
Merged
LTI1p3: update timezone handling to accomodate Canvas change#1189bnmnetp merged 1 commit intoRunestoneInteractive:mainfrom
bnmnetp merged 1 commit intoRunestoneInteractive:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the handling of assignment due dates received from LTI integrations by improving timezone awareness and ensuring due dates are accurately converted to the course's local time. The changes also update function signatures to pass the
courseobject where needed for timezone conversion.Timezone handling improvements:
update_rsassignment_from_ltifunction now normalizes ISO datetime strings with trailing "Z" (UTC) and, if both the incoming due date and the course have timezone information, converts the due date to the course's local timezone usingZoneInfo. Logging has been added for better traceability.Function signature and import updates:
update_rsassignment_from_ltifunction signature is updated to accept acourseparameter, and all calls to this function inlaunchandassign_selectare updated accordingly. [1] [2]Coursesmodel andZoneInfoare imported to support the new timezone logic. [1] [2]