Skip to content

update pretext version and refresh some files#259

Merged
bnmnetp merged 2 commits intoRunestoneInteractive:masterfrom
StevenClontz:update-ptx
Jun 20, 2023
Merged

update pretext version and refresh some files#259
bnmnetp merged 2 commits intoRunestoneInteractive:masterfrom
StevenClontz:update-ptx

Conversation

@StevenClontz
Copy link
Copy Markdown
Contributor

Oscar and I are working with John Cigas and this PR reflects any tweaks I would suggest.

@StevenClontz
Copy link
Copy Markdown
Contributor Author

I doubt this will fix all the problems, but maybe this gets things moving in the right direction.

@StevenClontz StevenClontz marked this pull request as ready for review June 20, 2023 20:28
@bnmnetp
Copy link
Copy Markdown
Member

bnmnetp commented Jun 20, 2023

Wow! You all had a very productive dropin today!

@bnmnetp bnmnetp merged commit 3bbe9ea into RunestoneInteractive:master Jun 20, 2023
@cigas
Copy link
Copy Markdown

cigas commented Jun 20, 2023

Found the (first!) real problem. It was from adding <introduction> divisions around <exercise>
from Eliminate Warnings on Build #253

@StevenClontz
Copy link
Copy Markdown
Contributor Author

Ah ha. Yup, introduction isn't as permissive as other content areas.

@StevenClontz
Copy link
Copy Markdown
Contributor Author

Something that surprises me here: @oscarlevin's pretext-tools plugin doesn't fire any warnings when I look at
image
in Codespaces. Is this my user error or a bug?

@oscarlevin
Copy link
Copy Markdown

oscarlevin commented Jun 20, 2023 via email

@StevenClontz
Copy link
Copy Markdown
Contributor Author

Maybe I'm confused on the issue. Is an exercise allowed by the schema in the introduction of a section? https://pretextbook.org/doc/schema/schemas/pretext_xsd/elements/introduction.html seems to suggest that's okay.

@oscarlevin
Copy link
Copy Markdown

oscarlevin commented Jun 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants