Skip to content

ESLint, Cleanup#32

Merged
bkendall merged 3 commits intomasterfrom
feature-cleanup
Apr 28, 2015
Merged

ESLint, Cleanup#32
bkendall merged 3 commits intomasterfrom
feature-cleanup

Conversation

@bkendall
Copy link
Copy Markdown
Contributor

Though this looks like a large change, the quick summary is that it's a lot of cleanup, and not a lot of functional changes:

  • Use eslint instead of jshint. New config is in place, and npm run lint is correct
  • Removed lodash! Functionality has been replaced by https://github.com/tjmehta/101 functions
  • Added testing for iojs. Since it's around, we may as well support it... though I think it will only be on 'best effort' from our side...
  • Cleaned up the README a little as well

@bkendall
Copy link
Copy Markdown
Contributor Author

@tjmehta I think I used the appropriate 101 things in replacing lodash. Could you take a quick once-over and make sure I did? The big one I had to change out was being able to just iterate over all the key-value pairs in an object (just went with Object.keys(...).map(...), since there's nothing I can think of that will easily do that in 101 - maybe an idea?).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange that we are calling newPort() here. But I can see that it works

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh - weird

@podviaznikov
Copy link
Copy Markdown
Member

looks good to me

bkendall added a commit that referenced this pull request Apr 28, 2015
@bkendall bkendall merged commit 11b27b9 into master Apr 28, 2015
@bkendall bkendall deleted the feature-cleanup branch April 28, 2015 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants