Handle name when creating a container and returning list of containers#55
Handle name when creating a container and returning list of containers#55bkendall merged 7 commits intoRunnable:masterfrom doganyazar:master
Conversation
|
nice! could you create tests for these new bits of functionality? |
|
Yeah I should have done that :) I will definitely do that in a couple of days when I am done with my current task. |
|
Ok I have just added a check to make sure same container name cannot be used. And added test for it and also for the original Names field. |
|
@doganyazar looks like your changes dropped the coverage levels below our minimum thresholds. From |
|
@doganyazar the |
|
Coverage seems fine now :) Do you think we can merge this guys? |
This reverts commit af38ce4.
|
Thanks @doganyazar ! |
|
Just going to wait until @bkendall has a chance to review this |
|
this looks good, @doganyazar. thanks for the tests. |
Handle name when creating a container and returning list of containers
I just wanted to add functionality to get container's name from /containers/create api.
I do not know why but Docker api returns each container's name in "Names" field when listing containers via /containers/json?all=1
(https://docs.docker.com/engine/reference/api/docker_remote_api_v1.21/#list-containers)