adding support for env value on create container#6
Merged
Conversation
Contributor
|
LGTM 👍 |
tjmehta
added a commit
that referenced
this pull request
Sep 25, 2014
adding support for env value on create container
Contributor
There was a problem hiding this comment.
well actually do we want to extend everything?
Contributor
There was a problem hiding this comment.
are there any start options that should not be in inspect?
Contributor
Author
There was a problem hiding this comment.
there probably are, but for ease of getting things rolling, we can do this (also possibly lets us to cool things for testing if we need to)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can be used for any value, actually, which is kinda nice :)