Skip to content

update styles + add notification #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 2, 2016
Merged

update styles + add notification #2

merged 6 commits into from
Dec 2, 2016

Conversation

@taylordolan
Copy link
Contributor

@taylordolan taylordolan commented Dec 1, 2016 •
edited by runnabro
Loading

@runnabot
Copy link

runnabot commented Dec 1, 2016 •
edited
Loading

Deployed rails-starter/update-style. View on Runnable.
From Runnable

tosih
tosih reviewed Dec 1, 2016
View reviewed changes
Copy link
Contributor

@tosih tosih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe we should remove the stylesheet link to bulma.css

app/views/todos/show.html.haml
@@ -1,7 +0,0 @@
.container
Copy link
Contributor

@tosih tosih Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove this. You will get an app error if you got to <navi_url>:3000/todos/#

Copy link
Contributor Author

@taylordolan taylordolan Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should just put the file back in?

Copy link
Contributor Author

@taylordolan taylordolan Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get that issue when I go to that address.

Copy link
Contributor

@tosih tosih Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean a number instead of #.

Copy link
Contributor

@tosih tosih Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://1903l4-rails-starter-staging-runnabledemo.runnableapp.com:3000/todos/1

Copy link
Contributor

@tosih tosih Dec 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can put the file back in with simple styling. People can't hit the link via UI, but people familiar with rails will try and hit the direct route if they are curious.

@runnabro runnabro merged commit 5a9df12 into master Dec 2, 2016
@runnabro runnabro deleted the update-style branch December 2, 2016 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tosih tosih tosih left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@taylordolan @runnabot @tosih @runnabro