Skip to content

Conversation

@unam98
Copy link
Collaborator

@unam98 unam98 commented Aug 28, 2025

📌 개요

✨ 작업 내용

  • 페이지 전환 시 캐싱의 편의를 위해 뷰페이저2 기반으로 리팩토링

✨ PR 포인트

📸 스크린샷/동영상

Summary by CodeRabbit

  • Refactor

    • Switched main navigation to a pager-based flow for smoother, faster tab changes with preloaded screens and synced bottom navigation.
    • Replaced the main container with a ViewPager layout; swipe between tabs is disabled for consistent navigation.
    • Reduced unnecessary logging to improve stability.
  • New Features

    • Enhanced app update check with more reliable fetching and a localized update dialog, including a direct link to the store.

@coderabbitai
Copy link

coderabbitai bot commented Aug 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors main navigation to ViewPager2 with a new FragmentStateAdapter, replaces fragment transactions with pager-based switching, updates layout to include ViewPager2, and disables swipe. Integrates Firebase Remote Config using resource defaults to trigger a non-cancelable update dialog and opens Play Store via an intent when required.

Changes

Cohort / File(s) Summary
Main activity refactor
app/src/main/java/com/runnect/runnect/presentation/MainActivity.kt
Replaces manual fragment transactions with ViewPager2 navigation; initializes and controls vp_main via MainPager; maps bottom nav selections to pager indices; removes Timber logs; updates remote config fetching using REMOTE_CONFIG_FETCH_INTERVAL_SECONDS and string resources; shows update dialog and opens Play Store via Intent.ACTION_VIEW.
ViewPager2 adapter
app/.../presentation/MainPager.kt
Adds MainPager FragmentStateAdapter with 4 pages: CourseMain, StorageMain, Discover, MyPage; caches created fragments; exposes item count and createFragment.
Layout update
app/src/main/res/layout/activity_main.xml
Replaces FrameLayout (fl_main) with ViewPager2 (vp_main), constrained between parent top and bottom navigation.
String resources
app/src/main/res/values/strings.xml
Adds update_dialog_title, update_dialog_message, update_dialog_btn_text, and default_version for remote config defaults and dialog text.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant BottomNav as Bottom Navigation
  participant MainActivity
  participant ViewPager2 as vp_main
  participant Adapter as MainPager
  participant Fragment as Page Fragment

  User->>BottomNav: Tap tab (drawing/storage/discover/my_page)
  BottomNav->>MainActivity: onNavigationItemSelected(itemId)
  MainActivity->>MainActivity: map itemId -> position
  MainActivity->>ViewPager2: setCurrentItem(position, false)
  ViewPager2->>Adapter: createFragment(position)? (lazy)
  Adapter-->>ViewPager2: Fragment instance
  ViewPager2-->>Fragment: Display selected page
  note over MainActivity,ViewPager2: User swipe disabled
Loading
sequenceDiagram
  autonumber
  participant MainActivity
  participant RC as Firebase Remote Config
  participant Dialog as Update Dialog
  participant PlayStore as Play Store

  MainActivity->>RC: setConfigSettings(fetchInterval=3600s)<br/>setDefaults(default_version)
  MainActivity->>RC: fetchAndActivate()
  RC-->>MainActivity: onComplete(remoteVersion)
  MainActivity->>MainActivity: compare remoteVersion vs localVersion
  alt version differs
    MainActivity->>Dialog: initUpdateDialog(strings.xml)
    Dialog-->>MainActivity: show (non-cancelable)
    Dialog->>PlayStore: Intent ACTION_VIEW (market URL)
  else up to date
    MainActivity-->>MainActivity: no action
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

A pager hops from tab to tab—so fleet!
Four cozy burrows, fragments neat.
A carrot-colored prompt: “Update, please!”
Remote winds whisper version keys.
With one quick leap to the store I go,
Thump-thump—new trails for Runnect’s flow! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b785942 and 4ff8474.

📒 Files selected for processing (4)
  • app/src/main/java/com/runnect/runnect/presentation/MainActivity.kt (3 hunks)
  • app/src/main/java/com/runnect/runnect/presentation/MainPager.kt (1 hunks)
  • app/src/main/res/layout/activity_main.xml (1 hunks)
  • app/src/main/res/values/strings.xml (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/bottom-navi-viewpager

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@unam98 unam98 merged commit e51282d into develop Aug 28, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants