-
Notifications
You must be signed in to change notification settings - Fork 1
바텀 네비바 뷰페이저2 사용 #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
바텀 네비바 뷰페이저2 사용 #365
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRefactors main navigation to ViewPager2 with a new FragmentStateAdapter, replaces fragment transactions with pager-based switching, updates layout to include ViewPager2, and disables swipe. Integrates Firebase Remote Config using resource defaults to trigger a non-cancelable update dialog and opens Play Store via an intent when required. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant BottomNav as Bottom Navigation
participant MainActivity
participant ViewPager2 as vp_main
participant Adapter as MainPager
participant Fragment as Page Fragment
User->>BottomNav: Tap tab (drawing/storage/discover/my_page)
BottomNav->>MainActivity: onNavigationItemSelected(itemId)
MainActivity->>MainActivity: map itemId -> position
MainActivity->>ViewPager2: setCurrentItem(position, false)
ViewPager2->>Adapter: createFragment(position)? (lazy)
Adapter-->>ViewPager2: Fragment instance
ViewPager2-->>Fragment: Display selected page
note over MainActivity,ViewPager2: User swipe disabled
sequenceDiagram
autonumber
participant MainActivity
participant RC as Firebase Remote Config
participant Dialog as Update Dialog
participant PlayStore as Play Store
MainActivity->>RC: setConfigSettings(fetchInterval=3600s)<br/>setDefaults(default_version)
MainActivity->>RC: fetchAndActivate()
RC-->>MainActivity: onComplete(remoteVersion)
MainActivity->>MainActivity: compare remoteVersion vs localVersion
alt version differs
MainActivity->>Dialog: initUpdateDialog(strings.xml)
Dialog-->>MainActivity: show (non-cancelable)
Dialog->>PlayStore: Intent ACTION_VIEW (market URL)
else up to date
MainActivity-->>MainActivity: no action
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
📌 개요
✨ 작업 내용
✨ PR 포인트
📸 스크린샷/동영상
Summary by CodeRabbit
Refactor
New Features