Skip to content

[Style] recommandPublicCourse #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuSuhwa-ve merged 2 commits into from
Jan 11, 2024
Merged

[Style] recommandPublicCourse #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d20bc
style: ๐Ÿ’„ ์˜คํƒ€์ˆ˜์ •
YuSuhwa-ve Jan 11, 2024
d389dfc
style: ๐Ÿ’„ ์˜คํƒ€ ์ˆ˜์ •
YuSuhwa-ve Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/runnect/server/common/constant/SortStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ public enum SortStatus {
SCRAP_DESC("scrap","scrapCount"),
DATE_DESC("date","createdAt");

private final String vlaue;
private final String value;
private final String property;
}
2 changes: 1 addition & 1 deletion src/main/java/org/runnect/server/common/resolver/sort/SortStatusIdResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public Object resolveArgument(@NotNull MethodParameter parameter, ModelAndViewCo
}

if(!Arrays.stream(SortStatus.values())
.map(sortStatus -> sortStatus.getVlaue())
.map(sortStatus -> sortStatus.getValue())
.collect(Collectors.toList())
.contains(splitQuery.get("sort").get(0))){
throw new BadRequestException(ErrorStatus.INVALID_SORT_PARAMETER_EXCEPTION,ErrorStatus.INVALID_SORT_PARAMETER_EXCEPTION.getMessage());
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/runnect/server/publicCourse/service/PublicCourseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,12 @@ public RecommendPublicCourseResponseDto recommendPublicCourse(Long userId, Integ
//3. page, sort ์— ๋”ฐ๋ผ ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๊ธฐ
List<RecommendPublicCourse> recommendPublicCourses = new ArrayList<>();
Page<PublicCourse> publicCourses = null;
if (SortStatus.SCRAP_DESC.getVlaue().equals(sort)) {
if (SortStatus.SCRAP_DESC.getValue().equals(sort)) {
publicCourses = publicCourseRepository.findAll(
PageRequest.of(pageNo - 1, PAGE_SIZE,
Sort.by(Sort.Direction.DESC, SortStatus.SCRAP_DESC.getProperty())));

} else if (SortStatus.DATE_DESC.getVlaue().equals(sort)) {
} else if (SortStatus.DATE_DESC.getValue().equals(sort)) {
publicCourses = publicCourseRepository.findAll(
PageRequest.of(pageNo - 1, PAGE_SIZE,
Sort.by(Sort.Direction.DESC, SortStatus.DATE_DESC.getProperty())));
Expand Down