[Feat]#125 - 내가 업로드한 코스 삭제 및 수정하기 기능 구현 #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
approved these changes
May 8, 2023
Comment on lines
+132
to
+164
| guard let isMyCourse = self.isMyCourse, let uploadedCourseDetailModel = self.uploadedCourseDetailModel else { return } | ||
|
|
||
| let cancelAction = UIAlertAction(title: "닫기", style: .cancel, handler: nil) | ||
|
|
||
| if isMyCourse == true { | ||
| let editAlertController = UIAlertController(title: nil, message: nil, preferredStyle: .actionSheet) | ||
| let courseEditVC = CourseEditVC() | ||
| courseEditVC.loadData(model: uploadedCourseDetailModel) | ||
| courseEditVC.publicCourseId = self.publicCourseId | ||
| let editAction = UIAlertAction(title: "수정하기", style: .default, handler: {(_: UIAlertAction!) in | ||
| self.navigationController?.pushViewController(courseEditVC, animated: false) | ||
| }) | ||
| let deleteVC = RNAlertVC(description: "코스를 정말로 삭제하시겠어요?") | ||
| deleteVC.rightButtonTapAction = { [weak self] in | ||
| deleteVC.dismiss(animated: false) | ||
| self?.deleteCourse() | ||
| } | ||
| deleteVC.modalPresentationStyle = .overFullScreen | ||
| let deleteAction = UIAlertAction(title: "삭제하기", style: .destructive, handler: {(_: UIAlertAction!) in | ||
| self.present(deleteVC, animated: false, completion: nil)}) | ||
| [ editAction, deleteAction, cancelAction].forEach { editAlertController.addAction($0) } | ||
| present(editAlertController, animated: false, completion: nil) | ||
| } else { | ||
| // 신고폼 올라오는 거(유저아이디가 내가 아닌 경우) | ||
| let reportAlertController = UIAlertController(title: nil, message: nil, preferredStyle: .actionSheet) | ||
| let formUrl = NSURL(string: "https://docs.google.com/forms/d/e/1FAIpQLSek2rkClKfGaz1zwTEHX3Oojbq_pbF3ifPYMYezBU0_pe-_Tg/viewform") | ||
| let formSafariView: SFSafariViewController = SFSafariViewController(url: formUrl! as URL) | ||
| let reportAction = UIAlertAction(title: "신고하기", style: .destructive, handler: {(_: UIAlertAction!) in | ||
| self.present(formSafariView, animated: true, completion: nil) | ||
| }) | ||
| [ reportAction, cancelAction ].forEach { reportAlertController.addAction($0) } | ||
| present(reportAlertController, animated: true, completion: nil) | ||
| } |
Collaborator
There was a problem hiding this comment.
함수가 커지는 것은 지양합시다! -> 함수 내부 코드들을 쪼개서 다른 함수들로 만들고 여기서 호출하는 식으로 각 함수의 역할을 분리하면 좋아요~!
가독성과 유지보수에 큰 영향을 줍니다! (객체지향의 SOLID 원칙에 대해 공부해보면 좋을 것 같아요!)
Collaborator
Author
There was a problem hiding this comment.
넵 !!! 지금 당장 해보려고 했으나 급한 불 끄고 깔끔하게 고쳐볼게용
| import Then | ||
| import Moya | ||
|
|
||
| class CourseEditVC: UIViewController { |
Collaborator
There was a problem hiding this comment.
혹시 이 뷰 se 같이 작은 폰에서 잘 스크롤 될까요?
Comment on lines
+42
to
+47
| // private let afterEditTopView = UIView() | ||
| // private let selectCouseLabel = UILabel().then { | ||
| // $0.text = "코스 선택" | ||
| // $0.font = .b6 | ||
| // $0.textColor = .g2 | ||
| // } |
| $0.tintColor = .g1 | ||
| } | ||
| private let totalCourseNum = UILabel().then{ | ||
| $0.text = "총 100개" |
Collaborator
There was a problem hiding this comment.
label text의 기본값은 테스트용으로만 처음에 넣고 잘 동작하는 걸 확인했으면 없애는게 좋아요!
실제 사용자가 이 뷰에 접근했을 때 서버 통신이 완료되기 전까지 계속 "총 100개"라는 텍스트를 봐야하는데 이건 좋지 않은 UX입니다!
Collaborator
Author
There was a problem hiding this comment.
넵 !! 다음 이슈 파서 반영하도록 하겠습니닷 ,,,!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈