-
Notifications
You must be signed in to change notification settings - Fork 6
[Feat]#125 - 내가 업로드한 코스 삭제 및 수정하기 기능 구현 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "#125-\uB0B4\uAC00\uADF8\uB9B0\uCF54\uC2A4\uC0AD\uC81C"
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3ed05ba
[Feat] #125 - 편집버튼추가
lee-yeonwoo2 347d483
[Fix] #git 에러 해결
lee-yeonwoo2 e56b6b4
[Merge] #125 - Merge
lee-yeonwoo2 bf2e163
[Feat]#125 - 신고하기 버튼 구글폼 연결
lee-yeonwoo2 5a34c1c
[Feat]#125 - 총코스라벨추가
lee-yeonwoo2 03af91c
[Merge] #125- merge.
lee-yeonwoo2 f517429
[Feat] #125 - CourseDetailVC연결
lee-yeonwoo2 35bb6a2
[Merge] #125 - conflict 해결
lee-yeonwoo2 e5471de
[Feat] #125 - CourseDetailVC 분기처리
lee-yeonwoo2 7dc094d
[Feat] #125 - Dto 생성
lee-yeonwoo2 5ccec82
[Feat] #125 - UpdateCourse 라우터 추가
lee-yeonwoo2 2e9ac3d
[Feat] #125 - 글수정 API 연결
lee-yeonwoo2 8667182
[Feat] #125 - 삭제 API 연결
lee-yeonwoo2 375e119
[Feat] #125 - 스페이스바누르면 업로드안되기 구현
lee-yeonwoo2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
Runnect-iOS/Runnect-iOS/Global/Resource/Assets.xcassets/ic_frame_edit.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Frame 2064.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "Frame 2064@2x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "Frame 2064@3x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Binary file added
BIN
+1.03 KB
...nnect-iOS/Global/Resource/Assets.xcassets/ic_frame_edit.imageset/Frame 2064.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.94 KB
...ct-iOS/Global/Resource/Assets.xcassets/ic_frame_edit.imageset/Frame 2064@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.78 KB
...ct-iOS/Global/Resource/Assets.xcassets/ic_frame_edit.imageset/Frame 2064@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
Runnect-iOS/Runnect-iOS/Network/Dto/CourseDetailDto/RequestDto/EditCourseRequestDto.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // | ||
| // EditCourseReguestDto.swift | ||
| // Runnect-iOS | ||
| // | ||
| // Created by YEONOO on 2023/05/06. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| // MARK: - EditCourseReguestDto | ||
|
|
||
| struct EditCourseRequestDto: Codable { | ||
| let title, description: String | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,4 +20,5 @@ struct UploadUser: Codable { | |
| let nickname: String | ||
| let level: Int | ||
| let image: String | ||
| let isNowUser: Bool? | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
함수가 커지는 것은 지양합시다! -> 함수 내부 코드들을 쪼개서 다른 함수들로 만들고 여기서 호출하는 식으로 각 함수의 역할을 분리하면 좋아요~!
가독성과 유지보수에 큰 영향을 줍니다! (객체지향의 SOLID 원칙에 대해 공부해보면 좋을 것 같아요!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 !!! 지금 당장 해보려고 했으나 급한 불 끄고 깔끔하게 고쳐볼게용