[Feat] #11 - MyPageVC UI 구현 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
approved these changes
Jan 2, 2023
Collaborator
lsj8706
left a comment
lsj8706
left a comment
There was a problem hiding this comment.
전체적으로 함수도 잘 나누어서 구현했네요~~! 👍
매우 잘했습니다..!!
코멘트 남긴 자잘한 부분들만 수정해서 push하고 머지해주세요~~!
|
|
||
| import UIKit | ||
|
|
||
| class ActivityRecordInfoVC: UIViewController { |
Collaborator
There was a problem hiding this comment.
더이상 상속하지 않을 class라면 앞에 final을 붙여요!
| extension MyPageVC { | ||
| @objc | ||
| private func touchUpGoalRewardInfoView() { | ||
| pushtoGoalRewardInfoVC() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈