[Fix] #144 - 1차 릴리즈 QA 반영 #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
수정창을 눌렀을 때 현재 닉네임을 입력창에 띄워주는 것으로 변경
해당 뷰에서 바텀네비게이션 제거
일러스트까지 스크롤 영역에 포함되도록 수정 (콜렉션뷰 섹션 분리)
이용약관 노션 연결
lsj8706
approved these changes
May 21, 2023
Comment on lines
125
to
129
| if isSelected { | ||
| activityRecordContainerView.image = ImageLiterals.imgRecordContainerSelected | ||
| } else { | ||
| activityRecordContainerView.image = ImageLiterals.imgRecordContainer | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if isSelected { | |
| activityRecordContainerView.image = ImageLiterals.imgRecordContainerSelected | |
| } else { | |
| activityRecordContainerView.image = ImageLiterals.imgRecordContainer | |
| } | |
| activityRecordContainerView.image = isSelected ? 이미지1 : 이미지2 |
이렇게 삼항 연산자로도 쓸 수 있을 거 같아요!
Comment on lines
+122
to
+123
| func numberOfSections(in collectionView: UICollectionView) -> Int { | ||
| return 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
생략
📮 관련 이슈