-
Notifications
You must be signed in to change notification settings - Fork 6
[Fix] #216 - 바텀 시트의 일부 기능을 수정 하였습니다. #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "#216---\uBC14\uD140-\uC2DC\uD2B8-\uC624\uB958-\uD574\uACB0"
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
642e452
[Fix] #216 - 바텀 시트 keyboardWillShow 코드 수정
thingineeer fc4f8ba
[Chore] #216 - 필요없는 코드 제거
thingineeer 24b650f
[Feat] #216 - 바텀 시트 PanGesture 추가
thingineeer 6efaaf4
[Chore] #216 - 백그라운드 색 임시 제거
thingineeer ff391f4
[Chore] #216 - 불필요한 코드, 주석 제거
thingineeer cc29518
[Fix] #216 - 필요 없는 레이아웃 제거
thingineeer ccd9041
[Feat] #216 - 코드 리뷰 반영
thingineeer ca324ba
[Chore] #216 - panGesture private 선언
thingineeer 2d07c79
[Style] #186 - background Alpha값 미세 조정
thingineeer 8651274
[Feat] #216 - 바텀시트 최종 작업
thingineeer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,4 +38,3 @@ class BaseView: UIView, BaseViewProtocol { | |
|
|
||
| func setLayout() { } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 무슨 코드인가요 ? 궁금해여
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UIPanGestureRecognizer의 Action메소드가 호출되면, translation은 마지막으로 손가락을 이동한 위치에서부터 계산되지 않고, 손가락을 끌기 시작한 원래 장소!! (즉, 처음
PanGesture를 시작한 위치)에서 계산됩니다.recognizer.setTranslation(CGPoint.zero, in: bottomSheetView)그래서 우리는 위 메소드를 0.0으로 호출하여‼️
UIPanGestureRecognizer에게 새로운 드래그 동작을 시작할 것임을 알리는 것이죠.우리가 드래그를 이어서 한다고 해서 드래그가 한~~~번~~ 이런게 아닙니다. 늘 지속 됩니다 드래그는
UIPanGestureRecognizer의Action메소드는 지속적이라고 그랬죠? 계속Action메소드를 호출하게 됩니다.한번
Action메소드가 호출될때마다 파라미터로 보내는view의translation을0,0으로 setting 해줘야만하는것이죠.안그러면 우리가 처음 드래그를 시작한 그 위치!!!에서 부터 계속 거리를 계산할것이니까요.
이해가 안된다면 해당 개념을 참고한 블로그에서 가져온 글이 있는데 참고하면 좋을 것 같습니다.!!
https://zeddios.tistory.com/356