-
Notifications
You must be signed in to change notification settings - Fork 6
[Feat] #229 - 코스 상세 스크랩 부분 API 변경으로 인한 코드 추가 구현, 코스 발견 이벤트 추가 작업을 하였습니다. #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thingineeer
merged 7 commits into
Runnect:develop
from
thingineeer:#229--코스발견-서버-API-부분-수정
Dec 27, 2023
The head ref may contain hidden characters: "#229--\uCF54\uC2A4\uBC1C\uACAC-\uC11C\uBC84-API-\uBD80\uBD84-\uC218\uC815"
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0a94c06
[Fix] #229 - 코스 스크랩 수 부분 수정
thingineeer 92ae95b
[Chore] #229 - 스크랩 toggle 부분 주석처리
thingineeer bf0488c
[Chore] #229 - cocoaPods 업데이트
thingineeer 15ddc61
[Feat] #229 - 코스 상세 스크랩 수 변경하는 부분 구현 완료
thingineeer d0abf38
[Chore] #229 - 변수 명명 규칙 수정
thingineeer 9222aed
[Feat] #229 - 마라톤 Cell도 UI 업데이트 되게 기능 구현
thingineeer feff494
[Chore] #229 - 프로토콜 네이밍 변경
thingineeer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...t-iOS/Runnect-iOS/Network/Dto/CourseDetailDto/ResponseDto/CourseDetailScrapCountDto.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // CourseDetailScrapCountDto.swift | ||
| // Runnect-iOS | ||
| // | ||
| // Created by 이명진 on 12/21/23. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
|
|
||
| struct CourseDetailScrapCountDto: Codable { | ||
| let scrapCount: Int | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
서버 통신에서 조금 바뀌었다고 했는데
원래는 scrap 개수가 response로 안넘어왔는데 지금은 넘어오고 그걸 사용하는 건가요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞아요
원래 +1 , -1 이런 식으로 그냥 단순한 방법으로 해결했었는데, 서버에서
scrapCount를 넘겨주니까 쉽게 해결할 수 있었어요!