[Feat] #49 - CourseUploadVC UI 구현 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
approved these changes
Jan 6, 2023
Collaborator
lsj8706
left a comment
lsj8706
left a comment
There was a problem hiding this comment.
점점 코드도 깔끔해지고 좋네요 🏅
함수가 길어서 발생하는 린트에러는 해당 함수를 분리해서 해결하면 됩니다...!
예를 들어 setLayout() 함수가 길다면 이 함수 안에서 scrollView 안에 있는 뷰들의 레이아웃을 잡는 코드들 만 때로 빼서 setScrollViewLayout() 이런 식으로 함수를 만들어서 분리하는 식으로요!
|
|
||
| extension CourseDiscoveryVC { | ||
| @objc private func presentToSearchVC() { | ||
| @objc private func pushToSearchVC() { |
| } | ||
|
|
||
| func textViewDidChange(_ textView: UITextView) { | ||
| if activityTextView.text.count > 150 { |
|
|
||
| extension CourseUploadVC: UITextViewDelegate { | ||
| func textViewDidBeginEditing(_ textView: UITextView) { | ||
| if textView.text.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty { |
Collaborator
There was a problem hiding this comment.
오호 UITextView Placeholder까지 깔끔하게 넣었네요 !
Runnect-iOS/Runnect-iOS/Presentation/CourseDiscovery/Views/CourseUploadVC.swift
Show resolved
Hide resolved
Runnect-iOS/Runnect-iOS/Presentation/CourseDiscovery/Views/MyCourseSelectVC.swift
Show resolved
Hide resolved
Runnect-iOS/Runnect-iOS/Presentation/CourseDiscovery/Views/CourseUploadVC.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
📮 관련 이슈