Skip to content

Feat: Code Coverage 적용#5

Merged
west-eastH merged 11 commits intodevelopfrom
feat/4-codeCoverage
Jun 25, 2025
Merged

Feat: Code Coverage 적용#5
west-eastH merged 11 commits intodevelopfrom
feat/4-codeCoverage

Conversation

@west-eastH
Copy link
Contributor

✨ 연관된 이슈

close #4


📝 작업 내용 (주요 변경 사항)

  • jacoco 플러그인 설치

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • jacocoTestReport에 커버리지 대상 제외할 클래스 추가하면 될 것 같아요!
  • jacoco.yml에서 전체 파일 최소 커버리지(50)랑 변경된 파일 최소 커버리지(70) 수정할 수 있습니당

@west-eastH west-eastH requested a review from choiseoji June 25, 2025 05:39
@west-eastH west-eastH self-assigned this Jun 25, 2025
@west-eastH west-eastH added the ✨feat 기능 개발 시 label Jun 25, 2025
@west-eastH west-eastH linked an issue Jun 25, 2025 that may be closed by this pull request
2 tasks
@west-eastH west-eastH changed the title Feat: Code Coverage Feat: Code Coverage 적용 Jun 25, 2025
@github-actions
Copy link

Test Coverage Report

There is no coverage information present for the Files changed

@github-actions
Copy link

Test Coverage Report

There is no coverage information present for the Files changed

@github-actions
Copy link

Test Coverage Report

There is no coverage information present for the Files changed

@github-actions
Copy link

Test Coverage Report

Overall Project 12.5% -15.63%
Files changed 44.44%

File Coverage
TestService.java 54.55% -45.45%
TestController.java 0%

@github-actions
Copy link

Test Coverage Report

There is no coverage information present for the Files changed

Copy link
Contributor

@choiseoji choiseoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!! 테스트코드 열심히 작성해보아요 🙌

- name: Create and inject jasypt secret into application-secret.properties
run: |
touch ./src/main/resources/application-secret.properties
echo "ENCRYPT_KEY=${{ secrets.ENCRYPT_KEY }}" > ./src/main/resources/application-secret.properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 환경변수는 어디서 관리하는건가요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 깃헙액션에서 자동으로 넣어준대요!

Comment on lines +60 to +61
'**/Q*.class',
'**/run/backend/BackendApplication.class'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기에 제외할 클래스 넣으면 되는거군요!

@github-actions
Copy link

Test Coverage Report

There is no coverage information present for the Files changed

Comment on lines +24 to +27
# - name: Create .env file for CI environment
# run: |
# touch .env
# echo "POSTGRES_HOST=${{ secrets.DB_HOST }}" >> .env
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choiseoji 환경변수 추가할 때마다 여기에 application.yml에서 사용하는 환경변수들 POSTGRES_HOST처럼 추가해주고 깃헙 시크릿키에도 등록 해줘야합니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하시고 머지 부탁드려요!

@github-actions
Copy link

Test Coverage Report

There is no coverage information present for the Files changed

@west-eastH west-eastH merged commit 0f43451 into develop Jun 25, 2025
1 check passed
@west-eastH west-eastH deleted the feat/4-codeCoverage branch June 25, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feat 기능 개발 시

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨feat : 테스트 커버리지 적용

2 participants