Skip to content

fix(detekt): Resolve detekt issues#67

Merged
Distractic merged 13 commits intochore/paper-migrationfrom
chore/documentation
Aug 6, 2023
Merged

fix(detekt): Resolve detekt issues#67
Distractic merged 13 commits intochore/paper-migrationfrom
chore/documentation

Conversation

@Quentixx
Copy link
Copy Markdown
Contributor

@Quentixx Quentixx commented Aug 6, 2023

In this pull request, I documented the classes and methods that weren't.
To do this, I followed the instructions of detekt.
I took the opportunity to reduce the MaxLineLength and NewLineAtEndOfFile warnings on the documentation.
I also re-implemented an extension function used in Hub and RTF projects that was removed in a previous commit.

Some other warnings was fixed:

  • removed obsolete ChatColor related method
  • Annotate deserialize methods by @OptIn for experimental use

@Quentixx Quentixx requested a review from Distractic August 6, 2023 16:49
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

57.8% 57.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Distractic Distractic changed the title Chore: Add documentation fix(detekt): Resolve detekt issues Aug 6, 2023
@Distractic Distractic merged commit 47a629d into chore/paper-migration Aug 6, 2023
@Distractic Distractic deleted the chore/documentation branch August 6, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants