feat(StringList): implement str_len#159
Conversation
Hey, @yingmanwumen. Thanks for the PR. |
tushushu
left a comment
There was a problem hiding this comment.
All looks good except the docstring, and please add some tests cases for this method. I mentioned that in another comment.
| return UltraFastList(self._values.starts_with(elem)) | ||
|
|
||
| def str_len(self) -> "UltraFastList": | ||
| """Return a list on the length of strings""" |
There was a problem hiding this comment.
Maybe """Return each element's string length of self.""" would be better:)
There was a problem hiding this comment.
^_^ OK, I'll modify it latter. I am not at expressing something in English and I am trying to practice. Thanks, have a good day~
tushushu
left a comment
There was a problem hiding this comment.
@yingmanwumen All look good, thanks for submitting this PR.
#131
The method behaves like:
But I don't know how to add a test case for this implementation.
First PR for
ulist^_^