gccrs: Implement typecheck for zero-variant enums #3686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
reviewed
Apr 3, 2025
philberty
requested changes
Apr 3, 2025
Member
philberty
left a comment
philberty
left a comment
There was a problem hiding this comment.
Just minor style thing and add in another fix please.
Polygonalr
force-pushed
the
issue-3530
branch
2 times, most recently
from
0d46f58 to
eb4793e
Compare
gcc/rust/ChangeLog: * typecheck/rust-tyty.h: Add new `ReprKind` enum to `ReprOptions`. * typecheck/rust-hir-type-check-base.cc: Handle setting of `repr_kind`. * typecheck/rust-hir-type-check-item.cc: New check for zero-variant enums. Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-base.cc: Set enum representing type properly if repr is an integer type. * typecheck/rust-hir-type-check-item.cc: Update comments. Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
philberty
reviewed
Apr 4, 2025
philberty
requested changes
Apr 4, 2025
Member
philberty
left a comment
philberty
left a comment
There was a problem hiding this comment.
just minor change to that comment then looks good to go
gcc/rust/ChangeLog: * typecheck/rust-tyty.h: Remove extra redundant comment. * typecheck/rust-hir-type-check-base.cc: Update comment on repr handling. Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3530
make check-rustpasses locallyclang-formatgcc/testsuite/rust/This quick fix is kind of an ugly one, since parsing of
reprtypes is not fully implemented yet. This merely adds a newReprKindtype similar to Rust'sReprFlags.I'm open to suggestions for improvements, or any tips on fully implementing the parsing
reprtypes properly.