Remove incorrect pointer cast in volatile_load intrinsic#244
Merged
LegNeato merged 1 commit intoRust-GPU:mainfrom Aug 7, 2025
Merged
Remove incorrect pointer cast in volatile_load intrinsic#244LegNeato merged 1 commit intoRust-GPU:mainfrom
volatile_load intrinsic#244LegNeato merged 1 commit intoRust-GPU:mainfrom
Conversation
The PassMode::Cast check was incorrectly casting the input pointer based on the return value's ABI mode. This is wrong because `volatile_load` reads raw memory at the pointer's target type...any ABI transformations should happen after loading, not on the pointer itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PassMode::Cast check was incorrectly casting the input pointer based on the return value's ABI mode. This is wrong because
volatile_loadreads raw memory at the pointer's target type...any ABI transformations should happen after loading, not on the pointer itself.