fix(nvvm): resolve Windows CI build failures#389
Open
Snehal-Reddy wants to merge 1 commit intoRust-GPU:mainfrom
Open
fix(nvvm): resolve Windows CI build failures#389Snehal-Reddy wants to merge 1 commit intoRust-GPU:mainfrom
Snehal-Reddy wants to merge 1 commit intoRust-GPU:mainfrom
Conversation
3 tasks
The tag name on GitHub was lowercase 'llvm-7.1.0', but the URL was hardcoded to use uppercase 'LLVM-7.1.0', which has no release assets. Also added an explicit HTTP response code check to catch download failures early with a descriptive error message instead of failing later with an 'UnexpectedEof' during archive unpacking.
774d08b to
ed7272a
Compare
Contributor
|
i pulled this into #386 if we want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cccrate attempts to compile the LLVM C++ shim (RustWrapper.cpp) using MSVC (cl.exe), it blindly passes all flags returned byllvm-config --cxxflags. Since the prebuilt LLVM was cross-compiled,llvm-configreturns GCC-style warning flags (e.g.-Wextra), which causes MSVC to fail with aD8021 : invalid numeric argument '/Wextra'error.Changes
-W*) when compiling the C++ shim if the target contains "msvc".Testing
Notes
This issue manifested as build failures specifically when running cargo build in a clean Windows environment where USE_PREBUILT_LLVM triggers.