Only decorate physically sized types with ArrayStride#239
Merged
Firestar99 merged 2 commits intoRust-GPU:mainfrom Apr 21, 2025
Merged
Only decorate physically sized types with ArrayStride#239Firestar99 merged 2 commits intoRust-GPU:mainfrom
Firestar99 merged 2 commits intoRust-GPU:mainfrom
Conversation
jwollen
requested review from
Firestar99,
LegNeato,
eddyb and
schell
as code owners
Firestar99
approved these changes
Apr 21, 2025
Member
Firestar99
left a comment
Firestar99
left a comment
There was a problem hiding this comment.
Thanks!
just fixed the lint errors so we can merge this
Collaborator
|
Thank you so much for the PR!! |
Contributor
Author
|
@eddyb Out of curiosity. if we reverted this, and SPIR-T needs this info, how would it work on valid non- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop decorating
RuntimeArraysof unsized types withArrayStride. Fixes thespirv-valrule:This already works correctly when using
qptrs.