Skip to content

Conversation

@Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Nov 26, 2025

ignore the branch name, just reusing the PR from a previous attempt

fixes CI on main, see #468

close #468

naga fails to transpile our spirv to hlsl
@Firestar99 Firestar99 changed the title cargo update difftest: force wgpu to use Vulkan, disable dx12 Nov 26, 2025
@Firestar99 Firestar99 marked this pull request as ready for review November 26, 2025 17:34
@Firestar99 Firestar99 enabled auto-merge November 26, 2025 17:35
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a bug filed on naga?

@Firestar99 Firestar99 added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@Firestar99
Copy link
Member Author

  • naga 27 has a fix for the incorrectly emitted hlsl, we're still on wgpu 26 (and thus naga 26)
  • curiously, this pipeline ran but the merge queue pipeline failed due to not finding a Vulkan driver
    • just gonna retry for now, may need more investigation

@Firestar99 Firestar99 added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 7034881 Nov 27, 2025
13 checks passed
@Firestar99 Firestar99 deleted the cargo-update branch November 27, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: difftests on windows failing due to wgpu DXC errors

4 participants