difftest: fix 5 difftests silently passing on zeroed inputs#567
Merged
LegNeato merged 1 commit intoRust-GPU:mainfrom Apr 14, 2026
Merged
difftest: fix 5 difftests silently passing on zeroed inputs#567LegNeato merged 1 commit intoRust-GPU:mainfrom
LegNeato merged 1 commit intoRust-GPU:mainfrom
Conversation
… them. Also fixes `trig_ops-rust` clamping asin's output instead of its input — the zero input was hiding it.
LegNeato
changed the title
Firestar99
approved these changes
Apr 14, 2026
Member
Firestar99
left a comment
Firestar99
left a comment
There was a problem hiding this comment.
Had a quick scroll through, looking good!
Won't verify every single comment against the shader since it's just tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes
trig_ops-rustclamping asin's output instead of its input.