rust: simplify file operations by removing FileOpener#617
Merged
wedsonaf merged 1 commit intoRust-for-Linux:rustfrom Jan 12, 2022
Merged
rust: simplify file operations by removing FileOpener#617wedsonaf merged 1 commit intoRust-for-Linux:rustfrom
FileOpener#617wedsonaf merged 1 commit intoRust-for-Linux:rustfrom
Conversation
It is currently used to allow a single `FileOperations` implementation to be shared by multiple `FileOpener` instances. But Binder is the only intended user I've seen so far. So we have the extra complexity because of a single exceptional case. This commit simplifies things for the majority: they just need to implement `FileOperations::open`. Signed-off-by: Wedson Almeida Filho <wedsonaf@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently used to allow a single
FileOperationsimplementationto be shared by multiple
FileOpenerinstances. But Binder is the onlyintended user I've seen so far.
So we have the extra complexity because of a single exceptional case.
This commit simplifies things for the majority: they just need to
implement
FileOperations::open.Signed-off-by: Wedson Almeida Filho wedsonaf@google.com