Build system review#627
Merged
ojeda merged 9 commits intoRust-for-Linux:rustfrom Jan 16, 2022
Merged
Conversation
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
It turns out that `__clang_version__` is not exactly the full version (e.g. it may not include the `-` suffix), thus we cannot compare the full versions -- we will have to wait until `bindgen` adds proper support for printing the full version. Also, made all version extraction a bit more robust and use the same pattern everywhere. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This should make the warnings more visible without having to run `rustavailable` manually. If it turns out to be too annoying, we can remove it later on. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Now that we have `RUST_IS_AVAILABLE` with more checks, we can "safely" remove `!COMPILE_TEST`. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This also makes it so that we enter `rust` on `clean`. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
…ules` Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses Masahiro's feedback, improves cleaning behavior and the
rust-is-availablescript.